Pandipipas/scoreko-dev
1
0
Fork 0
mirror of https://github.com/Pandipipas/scoreko-dev.git synced 2026-06-06 03:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix custom player id leaking in scoreboard input

Browse Source
This commit is contained in:
Pandipipas
2026-02-11 10:33:31 +01:00
parent 6d7e7b9b10
commit e7354500f4
1 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dashboard/example/components/ScoreboardPanel.vue
+28 -4
View File
@@ -70,10 +70,38 @@ const playerOptions = computed(() => {
return base.concat(options);
});
const leftPlayerOptions = computed(() => {
const options = filterOptions(playerOptions.value, leftFilter.value);
if (scoreboardStore.scoreboard.leftPlayerId !== CUSTOM_LEFT_PLAYER_ID) {
return options;
}
return [{
value: CUSTOM_LEFT_PLAYER_ID,
label: scoreboardStore.scoreboard.leftNameOverride || '(Sin asignar)',
}].concat(options);
});
const rightPlayerOptions = computed(() => {
const options = filterOptions(playerOptions.value, rightFilter.value);
if (scoreboardStore.scoreboard.rightPlayerId !== CUSTOM_RIGHT_PLAYER_ID) {
return options;
}
return [{
value: CUSTOM_RIGHT_PLAYER_ID,
label: scoreboardStore.scoreboard.rightNameOverride || '(Sin asignar)',
}].concat(options);
});
const leftSelectedPlayer = computed(() => playersStore.players[scoreboardStore.scoreboard.leftPlayerId]);
const rightSelectedPlayer = computed(() => playersStore.players[scoreboardStore.scoreboard.rightPlayerId]);
const getPlayerLabel = (playerId: string) => {
if (playerId === CUSTOM_LEFT_PLAYER_ID) {
return scoreboardStore.scoreboard.leftNameOverride;
}
if (playerId === CUSTOM_RIGHT_PLAYER_ID) {
return scoreboardStore.scoreboard.rightNameOverride;
}
const match = playerOptions.value.find((option) => option.value === playerId);
return match ? match.label : '';
};
@@ -135,10 +163,6 @@ const rightHasSelectedPlayerChanges = computed(() => {
|| player.country !== scoreboardStore.scoreboard.rightCountryOverride;
});
const leftPlayerOptions = computed(() => filterOptions(playerOptions.value, leftFilter.value));
const rightPlayerOptions = computed(() => filterOptions(playerOptions.value, rightFilter.value));
const startLeftCustomPlayer = () => {
const wasCustom = scoreboardStore.scoreboard.leftPlayerId === CUSTOM_LEFT_PLAYER_ID;
scoreboardStore.scoreboard.leftPlayerId = CUSTOM_LEFT_PLAYER_ID;